Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Fix formatting untitled file #65

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Fix formatting untitled file #65

merged 2 commits into from
Apr 9, 2018

Conversation

faustinoaq
Copy link
Member

Fixes #64

@faustinoaq faustinoaq requested a review from a team March 12, 2018 17:16
@faustinoaq faustinoaq changed the title Fix formatting unsaved document Fix formatting untitled file Mar 12, 2018
@kofno
Copy link
Contributor

kofno commented Mar 12, 2018

Should there be spec for that?

@faustinoaq
Copy link
Member Author

Should there be spec for that?

Oh, yeah, let me add some test 😅

keplersj
keplersj previously requested changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@keplersj keplersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the test and this will be good to go.

@faustinoaq faustinoaq dismissed keplersj’s stale review April 9, 2018 07:33

Tests were added

@faustinoaq faustinoaq requested a review from a team April 9, 2018 07:34
@faustinoaq faustinoaq merged commit b29a562 into master Apr 9, 2018
@faustinoaq faustinoaq deleted the fa/fix-formatting-unsaved-document branch April 9, 2018 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmulvihill bmulvihill bmulvihill approved these changes

@keplersj keplersj keplersj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faustinoaq @kofno @keplersj @bmulvihill